Add trigger for periodic topology snapshots #3188
Open
+622
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]> [ci] refactor Signed-off-by: Julien Tinguely <[email protected]>
julientinguely-da
force-pushed
the
julien/1133-periodic-snapshots-prod-cluster
branch
from
e7fee87 to
7a1cb7e
Compare
Signed-off-by: Julien Tinguely <[email protected]>
martinflorian-da
approved these changes
Nov 18, 2025
Contributor
martinflorian-da
left a comment
martinflorian-da
left a comment
There was a problem hiding this comment.
Thanks for your patience! It's very nice work, thank you!
I did collect a fair number of comments though... Let's do another iteration once you had a chance to look at them.
...t/scala/org/lfdecentralizedtrust/splice/integration/tests/PeriodicTopologySnapshotTest.scala
Show resolved
Hide resolved
...in/scala/org/lfdecentralizedtrust/splice/sv/automation/PeriodicTopologySnapshotTrigger.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/lfdecentralizedtrust/splice/sv/automation/PeriodicTopologySnapshotTrigger.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/lfdecentralizedtrust/splice/sv/automation/PeriodicTopologySnapshotTrigger.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/lfdecentralizedtrust/splice/sv/automation/PeriodicTopologySnapshotTrigger.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
julientinguely-da
force-pushed
the
julien/1133-periodic-snapshots-prod-cluster
branch
from
0a0875e to
826983f
Compare
Signed-off-by: Julien Tinguely <[email protected]>
julientinguely-da
force-pushed
the
julien/1133-periodic-snapshots-prod-cluster
branch
3 times, most recently
from
0c55738 to
21ecebc
Compare
sdf Signed-off-by: Julien Tinguely <[email protected]>
julientinguely-da
force-pushed
the
julien/1133-periodic-snapshots-prod-cluster
branch
from
21ecebc to
3943c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1133
test bucket: https://console.cloud.google.com/storage/browser/da-splice-topology-snapshots;tab=objects?forceOnBucketsSortingFiltering=true&project=da-cn-splice&prefix=&forceOnObjectsSortingFiltering=false
The plan would be to activate it on sv1 in our production clusters (will be available from 0.5.3).
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines