Add SendAsset action with EIP-712 signing#155
Merged
lmlmt merged 2 commits intohyperliquid-dex:masterfrom Oct 20, 2025
Merged
Conversation
Implement sendAsset functionality using proper EIP-712 typed data signing, aligned with the Hyperliquid API and hyperliquid-python-sdk specification. Key changes: - Add SendAsset struct with EIP-712 implementation - Implement send_asset() method using sign_typed_data - Support all required parameters: destination, sourceDex, destinationDex, token, amount - Handle fromSubAccount for vault/subaccount transfers - Support mainnet/testnet chain selection - Set vault_address to None for sendAsset actions (handled in post method) - Add comprehensive tests for signing with mainnet/testnet and vault scenarios This follows the same pattern as usdClassTransfer, replacing legacy L1 action signing with EIP-712 typed data for proper API compatibility.
lmlmt
approved these changes
Oct 20, 2025
src/exchange/exchange_client.rs
Outdated
|
|
||
| // Build fromSubAccount string (similar to Python SDK) | ||
| let from_sub_account = if let Some(vault_addr) = self.vault_address { | ||
| format!("{:?}", vault_addr) |
Contributor
There was a problem hiding this comment.
nit: `format!("{vault_addr:?}")
Contributor
There was a problem hiding this comment.
Also this can be written as self.vault_address.map_or(String::new(), format!("{vault_addr:?}")
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement sendAsset functionality using proper EIP-712 typed data signing, aligned with the Hyperliquid API and hyperliquid-python-sdk specification.
Key changes:
This follows the same pattern as usdClassTransfer, replacing legacy L1 action signing with EIP-712 typed data for proper API compatibility.