chore: updating code owners to team

[kotharironak]

No description provided.

[codecov]

Codecov Report

Merging #54 (c820ef3) into main (55de008) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #54   +/-   ##
=========================================
  Coverage     69.20%   69.20%           
  Complexity      106      106           
=========================================
  Files            15       15           
  Lines           565      565           
  Branches         33       33           
=========================================
  Hits            391      391           
  Misses          154      154           
  Partials         20       20           

Flag	Coverage Δ
unit	69.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[github-actions]

Unit Test Results

  9 files  ±0    9 suites  ±0   8s ⏱️ ±0s
31 tests ±0  31 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c820ef3. ± Comparison against base commit 55de008.

[aaron-steinfeld]

I don't have strong feelings either way, but I think I recall @skjindal93 had moved some repos away from team ownership, so might want to discuss that first.

[kotharironak]

I don't have strong feelings either way, but I think I recall @skjindal93 had moved some repos away from team ownership, so might want to discuss that first.

Team base approach makes it easy to add/remove members, isn't it? Or that's not the case?

[skjindal93]

I don't have strong feelings either way, but I think I recall @skjindal93 had moved some repos away from team ownership, so might want to discuss that first.

Team base approach makes it easy to add/remove members, isn't it? Or that's not the case?

Just that team based approach needs admin to add new code owners to the team

It becomes easy otherwise to update code owners, if they are just listed out in the CODEOWNERS file. Anyone can raise a PR to add them

[aaron-steinfeld]

Just that team based approach needs admin to add new code owners to the team

Not a global or repo admin though, a team maintainer. So if that's the approach we want, we could choose to make all (or just some) members of each team as maintainers.

[skjindal93]

Just that team based approach needs admin to add new code owners to the team

Not a global or repo admin though, a team maintainer. So if that's the approach we want, we could choose to make all (or just some) members of each team as maintainers.

I am fine with either approach, as long there is an easy way to add more code owners, and seems like there is. Though, it also becomes easy to see the enumerated code reviewers in a pull request, rather than clicking on the user group and inspecting the members