fix: use registerCallback in HasUuids and HasUlids traits #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
HasUuidsandHasUlidstraits define apublic function creating()instance method to hook into the model's creating event. This prevents models from defining their owncreating()method using Hyperf's instance method pattern:This also causes conflicts when multiple traits try to define the same event method.
Solution
Replace the instance method with
registerCallback()in a boot method:This allows:
creating()instance methodsChanges
HasUuids: Replacecreating()withbootHasUuids()usingregisterCallbackHasUlids: Replacecreating()withbootHasUlids()usingregisterCallback