Python refactor #1477
Open
Python refactor #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves problem when installing package directly from git (pipenv install -e )
- Except NULL for cdefs (slightly optimizes performance) - Handle reading NULLs from Options (caused segfault) - Improve handling of parameters for char* options - accepts string-like objects, returns bytes() - Use cython magic for __options - Handle None as NULL in SwapOnVSync (allows wait for sync usage) - Use C++ Canvas object to handle common operations - Use @Property decorator syntax - prevent creation of uninitialized objects from Python code (__new__) - prevent cython classes without corresponding C++ class (raise exception on all paths that can cause it) - Trace displayed FrameCanvas in SwapOnVSync - class passed to SwapOnVSync is returned on second call - Recycle FrameCanvas when python object is freed - FrameCanvas class keeps RGBMatrix alive (RGBMatrix is not deleted before FrameCanvas)
Export Serialize using Python Buffer Protocol Currently only read-only view is supported
``` green = Color(0, 255, 0) rgbmatrix.Fill(*green())
generated using: python3 -m cython -3 --cplus *.pyx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(For discussion)
Add support for FrameCanvas::Serialize: