Added multiplexing method for P4Outdoor80x40 display #1571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
reviewed
Jul 10, 2024
| result->push_back(new FlippedStripeMultiplexMapper()); | ||
| result->push_back(new P10Outdoor32x16HalfScanMapper()); | ||
| result->push_back(new P4Outdoor80x40Mapper()); | ||
| //result->push_back(new P4Outdoor80x40Mapper1()); |
Owner
There was a problem hiding this comment.
Did you mean to leave this commented-out line here ?
|
This code worked for me with this display. I've rebased the commits and removed the unneeded comment in my fork |
|
I've submitted a separate PR with my changes here #1723 - I wasn't sure if that was needed or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the display:
https://nl.aliexpress.com/item/1005003999341251.html?spm=a2g0o.order_list.order_list_main.11.408679d2q5LwTb&gatewayAdapt=
glo2nld