Updated ZStripeMultiplexMapper to support variable tile sizes #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks for a version of the 104*52 panels. Found from a forum post.
hzeller
requested changes
Jul 29, 2024
Owner
hzeller
left a comment
hzeller
left a comment
There was a problem hiding this comment.
Looks good in general, but make sure to not modify global variables messing with other instances of the same class.
| void MapSinglePanel(int x, int y, int *matrix_x, int *matrix_y) const { | ||
| static const int tile_width = 8; | ||
| static const int tile_height = 4; | ||
| static const int tile_width = width_; |
Owner
There was a problem hiding this comment.
if you use width_ and height_ member variables, you can't assign this to static variables here, as they are global and override them with whoever ran last.
Just replace all uses of tile_height, and tile_width with the new members height_ and width_.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allowed me to use the ZStripeMultiplexMapper with a tile height of 13, for an LED panel that required this change for the mapping to work
I decided to update ZStripeMultiplexMapper - rather than make a new mapping - because this change may be helpful for future panels that require different tile heights or widths, like mine.
I've updated the existing mappings so that their original tile size values (8 and 4) are accounted for.