fix: remove -march=native, to allow cross-compilation #1715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My machine, "cromwell": ``` $ uname -a Linux cromwell 6.1.0-25-amd64 hzeller#1 SMP PREEMPT_DYNAMIC Debian 6.1.106-3 (2024-08-26) x86_64 GNU/Linux ``` I tried to cross-compile, overriding `CXX` to use a cross-compiling toolchain. This failed because `-march=native` is not a valid value when cross-compiling from x86_64 to ARMv8. In the `lib` directory: ``` $ CXX=aarch64-linux-gnu-g++ CC=aarch64-linux-gnu-gcc make aarch64-linux-gnu-g++ -I../include -W -Wall -Wextra -Wno-unused-parameter -O3 -g -fPIC -DDEFAULT_HARDWARE='"regular"' -march=native -fno-exceptions -std=c++11 -c -o gpio.o gpio.cc cc1plus: error: unknown value ‘native’ for ‘-march’ cc1plus: note: valid arguments are: armv8-a armv8.1-a armv8.2-a armv8.3-a armv8.4-a armv8.5-a armv8.6-a armv8.7-a armv8.8-a armv8-r armv9-a make: *** [Makefile:192: gpio.o] Error 1 ``` With this change, compilation succeeds: ``` $ CXX=aarch64-linux-gnu-g++ CC=aarch64-linux-gnu-gcc make ``` produces `librgbmatrix.a` and `librgbmatrix.so.1` files just fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my (x86_64-bit Debian) machine:
I tried to cross-compile, overriding
CXXto use a cross-compilingtoolchain.
This failed because
-march=nativeis not a valid value whencross-compiling from x86_64 to ARMv8.
In the
libdirectory:With this change, compilation succeeds:
produces
librgbmatrix.aandlibrgbmatrix.so.1files just fine.