Skip to content

fix: select out of terminal #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamazy merged 1 commit into from
Aug 7, 2025
Merged

fix: select out of terminal #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions crates/egui-term/src/view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,11 @@ impl Widget for TerminalView<'_> {
fn ui(mut self, ui: &mut egui::Ui) -> Response {
let widget_id = self.widget_id;
let mut state = TerminalViewState::load(ui.ctx(), widget_id);
let mut layout_opt = None;

ui.horizontal(|ui| {
let size_p = Vec2::new(self.size.x - InteractiveScrollbar::WIDTH, self.size.y);
let (layout, painter) = ui.allocate_painter(size_p, egui::Sense::click());
let size_p = Vec2::new(self.size.x - InteractiveScrollbar::WIDTH, self.size.y);
let (layout, painter) = ui.allocate_painter(size_p, egui::Sense::click());

ui.horizontal(|ui| {
if layout.contains_pointer() {
*self.options.active_tab_id = Some(self.widget_id);
layout.ctx.set_cursor_icon(CursorIcon::Text);
Expand All @@ -82,7 +81,9 @@ impl Widget for TerminalView<'_> {

// context menu
if let Some(pos) = state.cursor_position {
self.context_menu(pos, &layout, ui);
if !out_of_terminal(pos, &layout) {
self.context_menu(pos, &layout, ui);
}
}
if ui.input(|input_state| input_state.pointer.primary_clicked()) {
state.cursor_position = None;
Expand Down Expand Up @@ -118,9 +119,8 @@ impl Widget for TerminalView<'_> {
term.show(&mut state, &layout, &painter);

state.store(ui.ctx(), widget_id);
layout_opt = Some(layout);
});
layout_opt.unwrap()
layout
}
}

Expand Down
Loading