You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a regression coming from #1697 author in VersionInfo must be nullable so we can still display content of some deleted user.
I have also reverted in AuthorsTab retrieving ownerId to be directly accessed from contentInfo instead of quering the owner as it might be no longer in the database.
I have reverted the fix to the pre regression state, I didn't want to go with option 2 as it wouldn't work without try catch since getOwner method returns proxy that is not a null even if the fetched user doesn't exist anymore, so we would have to fetch the ownerId of this object and handle the exception anyway
I decided to go for proxy resolving to avoid silencing null value for uninitialized proxy when non-existent user is accessed. This however needs to be deeper investigated concerning owner property coming from core VO.
The reason will be displayed to describe this comment to others. Learn more.
When I delete the editor and then go to the content tree, the error message box is displayed. Console shows: Failed to load resource: the server responded with a status of 404 (Not Found).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is a regression coming from #1697
authorinVersionInfomust be nullable so we can still display content of some deleted user.I have also reverted in
AuthorsTabretrievingownerIdto be directly accessed fromcontentInfoinstead of quering the owner as it might be no longer in the database.