Return otpServers with /project endpoint to allow speedup#514
Open
philip-cline wants to merge 2 commits intodevfrom
Open
Return otpServers with /project endpoint to allow speedup#514philip-cline wants to merge 2 commits intodevfrom
philip-cline wants to merge 2 commits intodevfrom
Conversation
Contributor
|
@philip-cline following on from your comment, have you noticed any performance issues with this change and is this related to your TODO? I.e. if there is a performance issue, should this update be rolled back? |
Contributor
Author
|
Let me do some testing on a large project deployment and see. The TODO is separate from the performance issue, that is more just for if this fix is permanent, then it doesn't really make sense to keep the field as a mixin. |
Contributor
Author
|
Yeah this seems to slow things down significantly for a big project. I'll do some work to maybe reduce the amount of data we need to request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Recent front end PRs (ibi-group/datatools-ui#895) have tried to reduce the amount of data that is unnecessarily requested by the front end. This endpoint created a conflict bc the /project and project:id differed in their return structure (specifically in returning otpServers).
Per the comment in the backend, I'm worried about performance issues with this change:

TODO: perhaps the ProjectWithOtpServers should not be a mixin anymore?