Skip to content

[patch] remove pre-install-rbac flag and rename the permission mode to admin mode#2330

Merged
durera merged 16 commits into
masterfrom
ds-admin
Jun 2, 2026
Merged

[patch] remove pre-install-rbac flag and rename the permission mode to admin mode#2330
durera merged 16 commits into
masterfrom
ds-admin

Conversation

@dixitgsathwara
Copy link
Copy Markdown
Contributor

@dixitgsathwara dixitgsathwara commented Jun 1, 2026

Description

  • rename the permissionMode to adminMode
  • enable the --admin-mode is compulsory for 9.2+ version
  • remove the --skip-preinstall-rbac flag and update the non-interactive flow
  • user who runs mas install command doesn't have cluster admin permission
    • without --no-confirm flag --> get the confirmation prompt ( has your cluster-administrator already applied require permission for your selected admin mode ?) YES --> skip rbac NO --> Fail with message
    • with --no-confirm --> the installation assumes the required RBAC has already been applied by your OpenShift administrator so skip rbac

Guidance for Reviewers

Testing

  • mas pre-install command
image
  • --admin-mode validation for 9.2+
image
  • mas install in interactive flow, test user with limited permission
image
  • non-interactive(testuser with limited permission) without --no-confirm
image
  • non-interactive(testuser with limited permission) with --no-confirm
image

@dixitgsathwara dixitgsathwara requested a review from a team as a code owner June 1, 2026 05:58
@durera durera merged commit 4265aad into master Jun 2, 2026
20 of 24 checks passed
@durera durera deleted the ds-admin branch June 2, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants