Adding abiltity to alter MQTT version using either envVars or ConfigFile#132
Open
JonahLuckett wants to merge 1 commit into
Open
Adding abiltity to alter MQTT version using either envVars or ConfigFile#132JonahLuckett wants to merge 1 commit into
JonahLuckett wants to merge 1 commit into
Conversation
May be redundant due to the current inability to use MQTTv5 but this way we're ready for the node update if we wanted to be.
Contributor
|
After various discussions today, have decided that we'll support MQTTv5 by making it a replacement for v3.1.1 rather than an alternative/configuration option ... supporting multiple versions will create additional overheads in terms of testing and code paths that we'll need to maintain as we start to take advantage of the v5 features, so after consideration we're going to tweak how we do this. Will discuss with you @JonahIBM once you're back from xmas hols .. should be a few simple tweaks we can make here to make it so that "it's just MQTT v5" |
herleraja
force-pushed
the
master
branch
3 times, most recently
from
49e89cb to
34ff138
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May be redundant due to the current inability to use MQTTv5 but this way we're ready for the node update if we wanted to be.