rerun daemonflux example notebook#883
Conversation
JanWeldert
left a comment
There was a problem hiding this comment.
You could delete some of the larger outputs to reduce the file size a bit (the diff doesn't show up in the online version), but apart from that it looks good.
|
Ah, I didn't notice that. I think it would be nice to keep the plots with differences vs Honda et al. I copied the plots to google slides: https://docs.google.com/presentation/d/1XSUcnCEL3wXcfXiWMZXQCg9NUIb5hE0GFxD5tF5KBKg/edit?usp=sharing |
|
@marialiubarska @JanWeldert Did both of you verify the notebook outputs (https://github.com/icecube/pisa/blob/db24838f292d1f31a7d5a192c239e2e1f6318b44/pisa_examples/test_daemonflux_stage.ipynb) here? 3 years of DRAGON should not have summed (neutrino) count expectations limited to ~160, but rather ~700. And indeed, when I run the notebook on the current master branch, the maximum bin count is around that level. (Or compare the IceCube_3y_oscillations_example.ipynb notebook.) Even my daemonflux/Honda ratio map looks different: In general, no settings should have changed when it comes to the public data sample, which is used by this notebook, and neither should the I have a modified version of this notebook in the works in #930 (so no need for a dedicated PR fixing this). |

updated the example notebook after bugfix