Fixed rmdir operation with recursion on non-existent directory#20
Open
Marv-CZ wants to merge 1 commit intoicetee:masterfrom
Open
Fixed rmdir operation with recursion on non-existent directory#20Marv-CZ wants to merge 1 commit intoicetee:masterfrom
Marv-CZ wants to merge 1 commit intoicetee:masterfrom
Conversation
Author
|
I found out it's not general problem, but only ftpd server from busybox which I used for testing. |
Author
|
For non-existent dirname: BusyBox ftpd Pure-FTPD ProFTPD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you call rmdir() with recursive=true on a non-existent directory it causes:
rmdir() calls list() which returns "No such file or directory" string instead a error and rmdir() tries to use it as a dir item.
I have replaced list() with listSafe() which is able to return the error, but it has bug too. It doesn't test missing optional arguments. So this patch also solves this issue.