Add fallback for Idris2 to use :type-of for eldoc-lookup #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keram
commented
Nov 16, 2025
| (if (and (stringp prop-val) (string-suffix-p ": " prop-val) (>=-protocol-version 2 1)) | ||
| (let* ((thing (idris-name-at-point)) | ||
| (ty (idris-eval (list :type-of thing) t)) | ||
| ;; (ty (idris-eval (list :docs-for thing) t)) |
Contributor
Author
There was a problem hiding this comment.
docs-for returns often multi line string which then causes mini-buffer to jump and distracts user.
Why: Idris2 IDE mode is lacking implementation of `doc-overview` attribute used in Idris 1 to display the short doc in minibuffer. This may be temporary until Idris2 implementation is updated.
keram
force-pushed
the
eldoc-idris2-fallback
branch
from
752f35c to
5e9a68f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Idris2 IDE mode is lacking implementation of
doc-overviewattribute used in Idris 1 to display the short doc in minibuffer.This may be temporary until Idris2 implementation is updated.
Before:
After:
Will keep this open as draft for while to test if there will be possible performance implications and open for feedback.
Of course best would be to to do changes in the idris2 itself but other's may consider this also useful meanwhile.