XEP-0478: Stream Limits Advertisement: initial support#692
Draft
stokito wants to merge 1 commit intoigniterealtime:masterfrom
Draft
XEP-0478: Stream Limits Advertisement: initial support#692stokito wants to merge 1 commit intoigniterealtime:masterfrom
stokito wants to merge 1 commit intoigniterealtime:masterfrom
Conversation
stokito
force-pushed
the
stream_limits
branch
from
f548329 to
fde3256
Compare
Add test for AbstractXMPPConnection.parseFeatures()
stokito
force-pushed
the
stream_limits
branch
from
fde3256 to
ad2b3dd
Compare
Flowdalic
requested changes
Feb 13, 2026
Member
Flowdalic
left a comment
Flowdalic
left a comment
There was a problem hiding this comment.
XEP-0478 is an experimental extension and hence does not belong in smack-core, please move the code into smack-experimental and refactor it accordingly.
| @@ -0,0 +1,90 @@ | |||
| /* | |||
| * | |||
| * Copyright © 2014-2026 Florian Schmaus | |||
Member
There was a problem hiding this comment.
I don't think I have the copyright on this code, have I?
| * If the responding entity is unable to determine its limits, this child can be absent. | ||
| * Element: <code><max-bytes/></code>. Type UnsignedInt. | ||
| */ | ||
| public final int maxBytes; |
Member
There was a problem hiding this comment.
Use UInt32 for xs:unsignedInt.
Suggested change
| public final int maxBytes; | |
| public final UInt32 maxBytes; |
| * If the responding entity is unable to determine its limits, this child can be absent. | ||
| * Element: <code><idle-seconds/></code>. Type UnsignedInt. | ||
| */ | ||
| public final int idleSeconds; |
Member
There was a problem hiding this comment.
Suggested change
| public final int idleSeconds; | |
| public final UInt32 idleSeconds; |
| public XmlStringBuilder toXML(XmlEnvironment enclosingNamespace) { | ||
| XmlStringBuilder xml = new XmlStringBuilder(this); | ||
| xml.rightAngleBracket(); | ||
| if (maxBytes != 0) { |
Member
There was a problem hiding this comment.
Use
xml.optElement()
now, since we denote the absence of the element with null.
Member
Author
|
I put it into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XEP-0478: Stream Limits Advertisement
I added the parsing of the
<limits>:It doesn't affect any logic, I'm not sure where to put the limits check.