-
Notifications
You must be signed in to change notification settings - Fork 167
Fix 2 reporting bugs #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2 reporting bugs #991
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
======================================
Coverage 92.2% 92.3%
======================================
Files 60 60
Lines 5155 5260 +105
======================================
+ Hits 4756 4855 +99
- Misses 399 405 +6
|
|
@Tyler-lc @junukitashepard FYI this PR will fix the two reporting issues we discussed last week. Per the PR checklist, I still need to update/expand the documentation to cover the features. You can wait until I do that and request review, or if curious you can check the tests to see the expected behaviour. |
|
I had a look at the diff and now it seems that historical and reference activities will be calculated with yv==ya right? But no choice regarding the method, at least for now. Which is fine by me. Just wanted to make sure that is the case. |
Actually there is a choice. I've now updated the docs; please see the preview build here which is supposed to explain. In brief:
The test (that was already on the branch) checks that (a) an exception is raised if the user does not provide share data and (b) the calculation succeeds if they do. |
- Globals, fixtures, tests. - Collect tests of Reporter class in TestReporter. - Alphabetize.
…instead of Generator.
Expose genno top-level items directly, instead of via ixmp.report.
|
Thanks @khaeru. I have tested the updates for historical out and it works as intended. |
junukitashepard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this historical output for my work and the update works as intended.
How to review
PR checklist