added vram detection and improved gpu formatting#174
Open
BrenoPT wants to merge 1 commit into
Open
Conversation
BrenoPT
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your pull request linked to an existing issue?
#156
What is your pull request about?:
I was trying to resolve the very verbose GPU name that shows up when fetching with the gpu stat enabled.
I saw that another issue had been opened and merged about this but I still had a problem displaying the gpu in my system for some reason.
So I added helper functions to cleanup the output from glxinfo and get the vram amount for discrete gpus to display alongside it.
Any other disclosures/notices/things to add?
I was afraid that this would significantly impact performance but after running a few tests it seems to not affect it that much, even though this adds a lot of code to the probe.
I used hyperfine and run the command in a single thread to measure performance, deleting the cache between runs, and the results I got are as follows:
Current build:
My build:
