Separate the implementations of get_disjoint_mut#443
Merged
cuviper merged 1 commit intoindexmap-rs:mainfrom May 2, 2026
Merged
Separate the implementations of get_disjoint_mut#443cuviper merged 1 commit intoindexmap-rs:mainfrom
get_disjoint_mut#443cuviper merged 1 commit intoindexmap-rs:mainfrom
Conversation
At first glance this may seem worse because it's roughly duplicating the `unsafe` code. However, these are now placed in a dedicated module where the parallels are apparent, and they should be more direct for their respective use-cases. * For disjoint key lookup in a map, we don't need to produce a `Result` that we're just going to turn into panics anyway. * For disjoint indices in a slice, we don't need to deal with `Option`, and we can drop our own unsafe implementation here in favor of the standard library once we update to MSRV 1.86.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At first glance this may seem worse because it's roughly duplicating the
unsafecode. However, these are now placed in a dedicated module where the parallels are apparent, and they should be more direct for their respective use-cases.Resultthat we're just going to turn into panics anyway.Option, and we can drop our own unsafe implementation here in favor of the standard library once we update to MSRV 1.86.