[FIX] l10n_uy_ux: Use report get params for e-rem#409
Open
zaoral wants to merge 1 commit into
Open
Conversation
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
Este PR ajusta la lógica de _get_report_params() en l10n_uy_ux para que el uso de parámetros de reporte aplique también a documentos tipo e-Remito, alineando el comportamiento con el resto de CFEs contemplados.
Changes:
- Se incluye el tipo de documento
l10n_uy.dc_e_remitodentro del conjunto de códigos habilitados para el parámetro de reporte"ingles".
Comment on lines
116
to
119
| | self.env.ref("l10n_uy.dc_cn_e_inv_exp") | ||
| | self.env.ref("l10n_uy.dc_dn_e_inv_exp") | ||
| | self.env.ref("l10n_uy.dc_e_remito") | ||
| ).mapped("code") |
There was a problem hiding this comment.
self.env.ref("l10n_uy.dc_e_remito") puede lanzar ValueError si ese XML ID no existe (p.ej. instalaciones con l10n_uy_ux sin l10n_uy_edi_stock, que es quien lo define en este repo). Para evitar que _get_report_params() falle al imprimir, conviene resolver la referencia de forma segura (raise_if_not_found=False) y sólo agregarla al recordset si existe, o bien declarar la dependencia explícita si realmente es obligatoria para este módulo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.