Fixes bug in electron and 3 vulnerabilities#523
Open
Josvanegmond wants to merge 1 commit into
Open
Conversation
Electron would crash after maximizing the window, which was fixed in version 30.0.6. Additionally three vulnerabilities are fixed on inefficient regular expressions and email address evaluation in quadratic time (though probably no impact on this project): GHSA-xf5p-87ch-gxw2, GHSA-rrrm-qjm4-v8hf, GHSA-5v2h-r2cx-5xgj.
|
@joethephish any thoughts on this Electron upgrade? Currently on Linux whenever you maximise or snap the window of Inky is crashes 100% of the time (tested on latest and previous Ubuntu LTS) Also as the window setup isn't persisted between sessions I have to manually resize the window to fullscreen after every launch. This would be a big QoL improvement :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electron would crash after maximizing the window, which was fixed in version 30.0.6.
Additionally three vulnerabilities are fixed on inefficient regular expressions and email address evaluation in quadratic time (though probably no impact on this project): GHSA-xf5p-87ch-gxw2, GHSA-rrrm-qjm4-v8hf, GHSA-5v2h-r2cx-5xgj.
Fixes #520