Update support of Fucheng-1 data#1451
Open
Arctic-Ambrun wants to merge 4 commits intoinsarlab:mainfrom
Open
Conversation
|
💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖 |
Contributor
Reviewer's GuideAdds initial support for the Fucheng-1 (FC1) SAR sensor by registering its aliases, defining its mission parameters, and wiring it into the mission lookup table used by MintPy/GAMMA workflows. Sequence diagram for FC1 sensor mission parameter lookupsequenceDiagram
actor Analyst
participant IngestScript
participant SensorModule
participant MissionTable
Analyst->>IngestScript: run_prep_gamma_with_metadata(meta_dict)
IngestScript->>SensorModule: get_unavco_mission_name(meta_dict)
SensorModule->>SensorModule: read platform_id from meta_dict
SensorModule->>SensorModule: normalize_platform_id(platform_id)
SensorModule->>SensorModule: map alias to key using sensor_name_dict
Note over SensorModule: fc1 and Fucheng aliases now map to key fc1
SensorModule->>MissionTable: lookup_mission_params(fc1)
MissionTable-->>SensorModule: FC1 mission_parameters
SensorModule-->>IngestScript: mission_name fc1 and parameters
IngestScript->>IngestScript: configure_gamma_processing(FC1 parameters)
IngestScript-->>Analyst: FC1 ready in MintPy GAMMA workflow
Flow diagram for FC1 alias resolution and mission parameter selectionflowchart TD
A[Start with metadata] --> B[Read platform_id]
B --> C[Normalize platform_id string]
C --> D{platform_id in sensor_name_dict aliases}
D -->|Matches FC1 alias fc1 Fucheng FuCheng1 FuCheng| E[Resolve sensor_key fc1]
D -->|Matches other sensor alias| F[Resolve sensor_key for other mission]
D -->|No match| G[Raise unsupported sensor error]
E --> H[Fetch FC1 params from mission_table]
H --> I[Use FC1 params in MintPy and GAMMA workflows]
F --> J[Fetch corresponding mission params]
J --> I
G --> K[Stop with error]
I --> L[End]
K --> L
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- There is a syntax error in the sensor alias map: the
'uav'entry ends with],,instead of a single comma, which will break module import and should be corrected. - For the new
'fc1'sensor aliases, consider normalizing the strings (e.g., all lowercase, consistent hyphenation) to match the existing pattern and avoid subtle mismatches when users specify the mission name.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There is a syntax error in the sensor alias map: the `'uav'` entry ends with `],,` instead of a single comma, which will break module import and should be corrected.
- For the new `'fc1'` sensor aliases, consider normalizing the strings (e.g., all lowercase, consistent hyphenation) to match the existing pattern and avoid subtle mismatches when users specify the mission name.
## Individual Comments
### Comment 1
<location> `src/mintpy/objects/sensor.py:33` </location>
<code_context>
'sen' : ['sen', 's1', 's1a', 's1b', 'sent1', 'sentinel1', 'sentinel1a', 'sentinel1b'],
'tsx' : ['tsx', 'terra', 'terrasar', 'terrasarx', 'tdx', 'tandemx'],
- 'uav' : ['uav', 'uavsar'],
+ 'uav' : ['uav', 'uavsar'],,
+ 'fc1' : ['fc1','fucheng', 'FuCheng-1', 'FuCheng'],
}
</code_context>
<issue_to_address>
**issue (bug_risk):** Remove the extra trailing comma in the UAV alias list to avoid a syntax error.
The double comma makes this line invalid Python. Remove the extra comma so it’s just:
```python
'uav' : ['uav', 'uavsar'],
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Update support of Fucheng-1 data. Tested in GAMMA+Mintpy.
Despite the difficulty in obtaining data from this satellite, I believe it will be widely used in the future.
Reminders
Summary by Sourcery
Add initial support for the Fucheng-1 (FC1) SAR satellite in MintPy’s sensor definitions.
New Features: