Open
Conversation
Owner
|
Thanks for the PR, I like having a single dark mode toggle in place - removes the temptation I was feeling to go all YAGNI while adding a single new theme 👍 I think some of the highlighting stuff I was playing about with in the example screenshot needed some content changes to support getting the blue highlights in the right place - will check when I'm back at the machine I did that on. |
|
Can we get this merged sooner than later? Literally the only thing keeping me from.using this exclusively. |
Collaborator
|
Friendly ping @insin in case he has a chance to review (it seemed like there were content adjustments necessary for the right highlights) 🐐 |
|
Bueller... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added dark mode to settings panel #54