-
Notifications
You must be signed in to change notification settings - Fork 475
Text Fragments from highlight experimental feature #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
schu96
wants to merge
5
commits into
internetarchive:master
Choose a base branch
from
schu96:text-selection-experimental
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
- Coverage 69.70% 69.19% -0.51%
==========================================
Files 65 65
Lines 5373 5512 +139
Branches 1182 1209 +27
==========================================
+ Hits 3745 3814 +69
- Misses 1594 1664 +70
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdrini
reviewed
Feb 3, 2026
Contributor
cdrini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We should put this behind a plugin.experiment for "show highlight menu" ; see https://github.com/internetarchive/bookreader/pull/1481/files for example of how we might do this
- We'll need this to work with the urlMode = history that prod uses; I'll set up a testbed for that.
- Use a different icon / designs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1363
Should allow users to highlight within the bookreader's text and generate a link with URI encoded parameters. The link is automatically copied to the user's clipboard and available for sharing with fellow patrons or new readers.
A test suite that validates the text fragment generation work is partially completed, just need some more specific example data to cover the remaining cases