Skip to content

Use the correct SPDX license identifier#128

Open
gtudan wants to merge 1 commit into
ionic-team:masterfrom
gtudan:patch-1
Open

Use the correct SPDX license identifier#128
gtudan wants to merge 1 commit into
ionic-team:masterfrom
gtudan:patch-1

Conversation

@gtudan
Copy link
Copy Markdown

@gtudan gtudan commented Oct 22, 2019

The license field in package.json should use a SPDX identifier for the license. https://docs.npmjs.com/files/package.json#license
"Apache 2.0" isn't quiet right according to https://spdx.org/licenses/
This breaks license checks plugins that do rather strict matching of the id.

The project root also contains a copy of the MIT license in LICENSE.md. Shouldn't that be Apache 2.0 as well?

The license field in package.json should use a SPDX identifier for the license. https://docs.npmjs.com/files/package.json#license
"Apache 2.0" isn't quiet right according to https://spdx.org/licenses/
This breaks license checks plugins that do rather strict matching of the id.

The project root also contains a copy of the MIT license in LICENSE.md. Shouldn't that be Apache 2.0 as well?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant