chore: cleanup inactive users and teams (2023-12-31 cut-off) #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed users inactive since 2023-12-31 from teams with push/maintain/admin
permissions and moved them to contributors team
changes made:
1. added 16 inactive users to contributors team:
andyschwab, anorth, arajasek, AuHau, daviddias, frrist, gmasgras,
Gozala, guseggert, ischasny, Kubuxu, masih, raulk, ribasushi,
travisperson, vmx, vyzo
2. removed 30 inactive users from teams with elevated permissions:
- admin (5): Kubuxu, arajasek, daviddias, marten-seemann, momack2
- Go Core Team (7): Kubuxu, dirkmc, guseggert, magik6k, masih,
ribasushi, warpfork
- JS Core Team (1): dirkmc
- Repos - Go (20): Kubuxu, adlrocha, anorth, daviddias,
dignifiedquire, dirkmc, frrist, gmasgras, guseggert, ischasny,
jacobheun, magik6k, marten-seemann, masih, petar, raulk,
ribasushi, travisperson, vyzo, warpfork
- Repos - JavaScript (7): AuHau, daviddias, dirkmc, Gozala,
jacobheun, momack2, vmx
- WG Captains (3): daviddias, momack2, raulk
- WG GUI/UX (2): andyschwab, ericronne
- comms (2): jesseclay, momack2
- community (1): TheDiscordian
- website-deployers (2): andyschwab, ericronne
3. removed empty teams and their repo permissions:
- deleted WG Project team (empty after cleanup)
- deleted WG Web Browsers team (empty after cleanup)
- removed both teams from all repo permissions
4. removed contributors team from all repo permissions:
- removed from 8 repos (1 push, 7 pull permissions)
- contributors and Alumni teams now have zero repo permissions
kept yiannisbot in Specs Stewards
the team had only one member (hsanjuan) who is now a member of shipyard team, no need for global Maintainers permission. removed Maintainers team from all 86 repos and deleted the team definition.
the team had only one member (hsanjuan) who is now a member of shipyard team, no need for this team. removed WG IPFS Cluster team from 2 repos and deleted the team definition.
the team had 2 members (hsanjuan, olizilla) who are already members of other teams with appropriate permissions. removed WG Infrastructure team from 2 repos and deleted the team definition.
the team had 6 members who are already members of gui-dev team which has appropriate permissions. removed WG GUI/UX team from 8 repos and deleted the team definition.
the team had 3 members (alanshaw, olizilla, Stebalien) who are already members of other teams with appropriate permissions. removed WG Captains team from 2 repos and deleted the team definition.
the team had 4 members: cwaring is no longer active, while lidel, achingbrain, and olizilla already have appropriate permissions via shipyard team. removed redundant team to make permissions easier to audit. removed website-deployers from 3 repos and deleted the team definition.
the go-ipfs-priv repository itself is archived and the team is not used by any active repositories. removed the team definition.
both users no longer work on IPFS (left PL/Shipyard recently). removed them from active teams (Go Core Team, Repos - Go, Repos - JavaScript, gui-dev) and moved to contributors team.
- Alumni: added description noting team contains people who contributed to IPFS in Protocol Labs era (<2024), with no repository permissions - contributors: added description noting team contains contributors who are no longer active or do not require extra permissions, with no repository permissions
Contributor
|
The following access changes will be introduced as a result of applying the plan: Access Changes |
Contributor
|
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansTerraform plans are too long to post as a comment. Please inspect Plan > Comment > Show terraform plans instead. |
Contributor
|
@lidel Let me know if you need a hand with the cleanup :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is a WIP draft, so we can see the impact once the CI dry-run shows exact permission changes.
IT IS NOT FINISHED, there are many broad permissions that are not accounted for yet.
Once ready, we will ping for review (or close without merge).
Summary
This PR is reducing permissions for users who haven't engaged with IPFS since nucleation (end of 2023), and cleaning up remaining redundant/dead teams.
Cutoff: 2023-12-31 - users with no public IPFS activity after this date will have elevated permissions removed.
DRI: myself
Why do you need this?
What changed
Each commit message includes details and rationale.
Impacted users
The changes were based on best-effort scan of "last activity" in the ipfs github org and cleaning up empty/redundant teams.
Note: some users marked their profiles as "private" which means this could not be a berfect representation of reality, but a very close approximation.
If we overstep anywhere, it can be fixed by restoring permissions in a separate PR, explaining why someone needs elevated permissions.
travispersonRepos - GojesseclaycommsdignifiedquireRepos - GoAuHauRepos - JavaScriptdaviddiasRepos - Go,Repos - JavaScript,WG Captains,WG Project,adminadlrochaRepos - GofrristRepos - GovyzoRepos - GoanorthRepos - GohugomrdiasWG Web BrowsersarajasekadminandyschwabWG GUI/UX,website-deployersKubuxuGo Core Team,Repos - Go,admingmasgrasRepos - GopetarRepos - GoericronneWG GUI/UX,website-deployersGozalaRepos - JavaScript,WG Web BrowserswarpforkGo Core Team,Repos - GojacobheunRepos - Go,Repos - JavaScriptdirkmcGo Core Team,JS Core Team,Repos - Go,Repos - JavaScriptTheDiscordiancommunityguseggertGo Core Team,Repos - Gomomack2Repos - JavaScript,WG Captains,WG Project,admin,commsischasnyRepos - GovmxRepos - JavaScriptmarten-seemannRepos - Go,adminraulkRepos - Go,WG Captainsmagik6kGo Core Team,Repos - GowhizzzkidWG GUI/UX,gui-devalanshawWG Captains,WG GUI/UXolizillaWG Captains,WG GUI/UX,WG Infrastructure,website-deployerscwaringWG GUI/UX,website-deployershacdiasGo Core Team,Repos - Go,Repos - JavaScriptStebalienWG Captains,go-ipfs-privJorropogo-ipfs-privachingbrainwebsite-deployershsanjuanMaintainers,WG IPFS Cluster,WG Infrastructureaschmahmanngo-ipfs-privlidelWG GUI/UX,WG Web Browsers,website-deployersmasihGo Core Team,Repos - GoribasushiGo Core Team,Repos - GoReviewer's Checklist