Skip to content

fix: allow routings to use helia components #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 13, 2025
Merged

fix: allow routings to use helia components #900

merged 5 commits into from
Nov 13, 2025

Conversation

@achingbrain
Copy link
Member

@achingbrain achingbrain commented Nov 13, 2025

Accept factory functions as routings, not just implementations.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: allow routings to use helia components
403c859 
Accept factory functions as routings, not just implementations.
@achingbrain achingbrain requested a review from a team as a code owner November 13, 2025 05:10
@achingbrain achingbrain merged commit cc90a4d into main Nov 13, 2025
18 checks passed
@achingbrain achingbrain deleted the fix/allow-routings-to-use-components branch November 13, 2025 05:42
@achingbrain achingbrain mentioned this pull request Nov 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@achingbrain