[Codegen] Add FusePCFWritesPass #22914
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshRavishankar
approved these changes
Dec 23, 2025
Collaborator
MaheshRavishankar
left a comment
MaheshRavishankar
left a comment
There was a problem hiding this comment.
Ha! Easier PR to review compared to the others. Good to go!
compiler/src/iree/compiler/Codegen/Dialect/PCF/Transforms/FusePCFWrites.cpp
Show resolved
Hide resolved
kuhar
approved these changes
Dec 29, 2025
compiler/src/iree/compiler/Codegen/Dialect/PCF/Transforms/FusePCFWrites.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/PCF/Transforms/FusePCFWrites.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/PCF/Transforms/FusePCFWrites.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/PCF/Transforms/FusePCFWrites.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/PCF/Transforms/FusePCFWrites.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/PCF/Transforms/FusePCFWrites.cpp
Outdated
Show resolved
Hide resolved
qedawkins
force-pushed
the
users/qedawkins/pcf-transforms-fuse-writes
branch
from
c6b4cf5 to
7c630ab
Compare
qedawkins
force-pushed
the
users/qedawkins/pcf-transforms-fuse-consumers
branch
from
092c3d4 to
3735172
Compare
Adds the FusePCFWritesPass which consolidates pcf.write_slice ops in loop bodies by fusing them with tensor.parallel_insert_slice operations from scf.forall terminators. When a pcf.write_slice writes to an sref that is produced by an scf.forall result, this pass composes the offsets, sizes, and strides of both operations to create a single write_slice inside the forall body. The implementation is exposed through the helper composeWriteSliceWithParallelInsert for use within larger passes.
qedawkins
force-pushed
the
users/qedawkins/pcf-transforms-fuse-writes
branch
from
7c630ab to
b061486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the FusePCFWritesPass which consolidates pcf.write_slice ops in loop bodies by fusing them with tensor.parallel_insert_slice operations from scf.forall terminators.
When a pcf.write_slice writes to an sref that is produced by an scf.forall result, this pass composes the offsets, sizes, and strides of both operations to create a single write_slice inside the forall body.
The implementation is exposed through the helper
composeWriteSliceWithParallelInsert for use within larger passes.