[HAL] Avoid segfault in dealloca verifier #22988
Open
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Sommer <[email protected]>
sommerlukas
commented
Dec 29, 2025
| Value signalFence) { | ||
| if (waitFence == signalFence && | ||
| !isa<IREE::Util::NullOp>(waitFence.getDefiningOp())) { | ||
| !isa_and_present<IREE::Util::NullOp>(waitFence.getDefiningOp())) { |
Contributor
Author
There was a problem hiding this comment.
I've decided to be conversative in the case that the fence is block argument and raise the error if wait and signal fence are identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid segmentation fault when verifying fences in case the fence is a block argument and therefore does not have a defining operation.
This is based on the bug reported from fuzzing and fixes #22960.