Readme improvements and a new version of Get#14
Open
vadim0x60 wants to merge 7 commits intoiron-io:masterfrom
Open
Readme improvements and a new version of Get#14vadim0x60 wants to merge 7 commits intoiron-io:masterfrom
vadim0x60 wants to merge 7 commits intoiron-io:masterfrom
Conversation
ghost
assigned
There was a problem hiding this comment.
Seems a little weird to mix the proper noun (Message) with the common noun (the message). Standardising on one would probably be better.
…empty "get" function waits for a message to be pushed into the queue
…ueue is empty "get" function waits for a message to be pushed into the queue" This reverts commit aa7399a. Reverted the previous commit as unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements by Vadim Liventsev