Fixes grasp for Automate environments#4157
Conversation
Greptile OverviewGreptile SummaryThis PR addresses two bugs in the AutoMate assembly environments:
The changes simplify the codebase by removing unnecessary CUDA version checking logic while enabling proper CUDA 13 support through updated dependencies ( Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant AssemblyEnv
participant SoftDTW
participant CUDA
User->>AssemblyEnv: Reset Episode
AssemblyEnv->>AssemblyEnv: _reset_idx()
AssemblyEnv->>AssemblyEnv: randomize_initial_state()
AssemblyEnv->>AssemblyEnv: Close gripper (1.0s grasp time)
Note over AssemblyEnv: Previously 0.25s, now 1.0s<br/>ensures full grasp
User->>AssemblyEnv: Step (action)
AssemblyEnv->>AssemblyEnv: _get_rewards()
AssemblyEnv->>SoftDTW: Compute DTW reward
SoftDTW->>CUDA: GPU computation (always enabled)
Note over SoftDTW,CUDA: CUDA version check removed<br/>Now uses numba.cuda import
CUDA-->>SoftDTW: DTW result
SoftDTW-->>AssemblyEnv: Imitation reward
AssemblyEnv-->>User: reward, done
|
There was a problem hiding this comment.
Additional Comments (1)
-
docs/source/overview/environments.rst, line 276-277 (link)style: Missing blank line before
.. code-block::directive. In RST, directives should have a blank line before them for proper rendering.
4 files reviewed, 1 comment
2ef7fc8 to
f3061a4
Compare
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
# Description 1. Fix the problem of success criterion. The root cause is not the reward design. The weird behavior is because the finger does not fully grasp the plug, i.e., the white part, before moving to the target end-effector pose. Therefore, I increase the grasp time at the reset of each episode to ensure that the finger fully grasp the plug. 2. Fix the problem that dtw reward computation does not work with CUDA 13. To run AutoMate with CUDA 13, it requires updated packages of numba-cuda[cu13], coverage, and pytorch. I update the documentation to explain this requirement. ## Type of change - Bug fix (non-breaking change which fixes an issue) - Documentation update ## Screenshots Please attach before and after screenshots of the change if applicable. Before: <img width="486" height="348" alt="Screenshot from 2025-12-05 10-08-36" src="https://github.com/user-attachments/assets/b6800456-9ff9-4feb-9249-1aa02fe6ec4c" /> After: <img width="500" height="363" alt="Screenshot from 2025-12-05 10-04-47" src="https://github.com/user-attachments/assets/f2e41859-7ea2-466c-bb49-4d6e1ca545aa" /> ## Checklist - [ x ] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ x ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ x ] I have made corresponding changes to the documentation - [ x ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ x ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
Description
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.

Before:
After:

Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there