stackSentinel background task fix#271
stackSentinel background task fix#271hardreddata wants to merge 8 commits intoisce-framework:mainfrom
Conversation
There was a problem hiding this comment.
Unrelated to this specific PR, but I would suggest to simplify write_wrapper_config2run_file() by:
- set default
line_cnt=1 - change
if line_cnt == numProcesstoif line_cnt % numProcess == 0
In this way, the input line_cnt is the actual line index, so we don't need to return this variable, thus, shorten all calls of the func from:
line_cnt = configObj.write_wrapper_config2run_file(configName, line_cnt)
to
configObj.write_wrapper_config2run_file(configName, line_cnt)
|
@yunjunz I would be happy to change to in the three occurrences. I left as above as it might be simpler to follow. Presently the stackSentinel.py |
|
Thank you for getting back to this @RussellGrew. Could you do the following?
I would prefer the latter one. We don't need to show the details if we don't have to. |
|
@yunjunz I think that is everything. |
|
These two still stand I believe:
|
|
That should be much closer. You did this to yourself with your notes of encouragement on https://mintpy.readthedocs.io/en/latest/#5_contributing I see the CI has now passed. I am not familiar with these new ionosphere steps. I checked that the config is written out, and that step 17 and 18 which consider the Cheers. |
yunjunz
left a comment
There was a problem hiding this comment.
LGTM. Thank you @RussellGrew!
There is a problem with #223 in which any tasks running in the background will continue in the background when the next step of the process begins (eg: run_03 can bleed into run_04). This causes issues when some steps try and use incomplete data.
The proposed solution writes a final
waitin any shell scripts which leveragenum_process.I welcome any feedback.