Added new authority for client management (#9184)

[RostyslavZadyraichuk]

Changed:

• added EDIT_CLIENT authority;
• updated pickup employee with new authority;

Summary by CodeRabbit

• Database Changes
  • New client editing authority permissions provisioned to designated roles and users.

[coderabbitai]

Walkthrough

This pull request adds a new Liquibase database changelog that introduces a new EDIT_CLIENT authority with id 36, mapping it to positions and linking it to an employee user account through database insertions.

Changes

Cohort / File(s)	Summary
Database changelog registration dao/src/main/resources/db/changelog/db.changelog-master.xml	Added include directive for new changelog entry ch-add-client-edit-authority-Zadyraichuk.xml
New authority and mappings dao/src/main/resources/db/changelog/logs/ch-add-client-edit-authority-Zadyraichuk.xml	Introduced two changesets: one inserting EDIT_CLIENT authority (id 36) with English/Ukrainian descriptions and position mappings (positions 6, 7); second inserting employee-authority mapping for user 2

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Column naming consistency: Verify the distinction between authority_id and authorities_id columns across the two changesets to ensure correct table schema mapping
• Authority id uniqueness: Confirm that authority id 36 doesn't conflict with existing authorities in the system
• Position and user ids: Validate that position ids (6, 7) and user id (2) exist in the database prior to these inserts

Poem

🔐 A new authority takes the stage,
EDIT_CLIENT writes on the page,
Positions dance, users align,
Permissions flow in perfect line,
Authority granted, now complete! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Added new authority for client management' directly reflects the main changes: adding an EDIT_CLIENT authority and updating an employee with this new authority.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 9184/add-user-status-column-to-clients-table

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

dao/src/main/resources/db/changelog/logs/ch-add-client-edit-authority-Zadyraichuk.xml (1)

5-28: Document the rationale for hard-coded IDs.

The changesets use several hard-coded database IDs:

• Authority ID: 36
• Position IDs: 6 and 7 (lines 14, 18)
• User ID: 2 (line 25, for the pickup employee)

Hard-coded IDs can become maintenance issues if the database schema evolves (e.g., if authorities or positions are added/removed/reordered). Consider adding inline comments explaining:

• Why authority ID 36 was chosen (is it the next available ID?)
• Which positions are 6 and 7, and why they need EDIT_CLIENT authority
• Why user ID 2 is the pickup employee (and whether this assumption holds across deployments)

Alternatively, if these are conventions known to your team, document them in the PR description or in a schema diagram.

dao/src/main/resources/db/changelog/db.changelog-master.xml (1)

41-41: Path format inconsistency in include statement.

The new include statement (line 41) uses the format db/changelog/logs/... without a leading slash, which is consistent with most other includes. However, lines 24 and 29 use a leading slash (/db/changelog/logs/...). While both formats may work, this inconsistency could be a minor maintenance concern.

Consider verifying whether path formats are standardized in this project, and align the new include accordingly if needed.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f3a982a and 0d0cec4.

📒 Files selected for processing (2)

• dao/src/main/resources/db/changelog/db.changelog-master.xml (1 hunks)
• dao/src/main/resources/db/changelog/logs/ch-add-client-edit-authority-Zadyraichuk.xml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build

🔇 Additional comments (1)

dao/src/main/resources/db/changelog/logs/ch-add-client-edit-authority-Zadyraichuk.xml (1)

5-21: No action required — column names verified.
positions_authorities_mapping defines "authorities_id" (ch-add-table-positions-authorities-mapping-Korzh.xml) and employee_authorities_mapping defines "authority_id" (ch-changed-user-role-to-varchar.xml / ch-insert-into-employee-authority-mapping-Korzh.xml); the inserts in ch-add-client-edit-authority-Zadyraichuk.xml use the correct column names.