Add list of calculators #1046
Open
Add list of calculators #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1034-api-for-calc #1046 +/- ##
=====================================================
+ Coverage 99.02% 99.05% +0.02%
=====================================================
Files 71 74 +3
Lines 1128 1158 +30
=====================================================
+ Hits 1117 1147 +30
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hanna4007
force-pushed
the
1036-list-of-calculators
branch
from
d41e95f to
4697448
Compare
MaksRudyk
requested changes
May 13, 2025
| @@ -0,0 +1,13 @@ | |||
| class Api::V2::CalculatorsController < Api::V2::ApplicationController | |||
| def index | |||
| calculators = collection.order_by_name(params[:name]) | |||
Contributor
There was a problem hiding this comment.
Можливо варто запермітити параметри?
Collaborator
There was a problem hiding this comment.
ну це ж не всі параметри передаються
Collaborator
There was a problem hiding this comment.
але до речі та, давай краще запермітим
Comment on lines
4
to
5
| let!(:calculator1) { create(:calculator, en_name: "Calculator_1", uk_name: "Калькулятор_1", en_notes: "Note_1", uk_notes: "Опис_1") } | ||
| let!(:calculator2) { create(:calculator, en_name: "Calculator_2", uk_name: "Калькулятор_2", en_notes: "Note_2", uk_notes: "Опис_2") } |
| get "/en/api/v2/calculators.json" | ||
|
|
||
| expect(response).to be_successful | ||
| json = response.parsed_body |
Contributor
There was a problem hiding this comment.
don't use local variables in tests
| get "/en/api/v2/calculators.json", params: { name: "desc" } | ||
|
|
||
| expect(response).to be_successful | ||
| json = response.parsed_body |
loqimean
reviewed
May 16, 2025
| @@ -0,0 +1,13 @@ | |||
| class Api::V2::CalculatorsController < Api::V2::ApplicationController | |||
| def index | |||
| calculators = collection.order_by_name(params[:name]) | |||
Collaborator
There was a problem hiding this comment.
ну це ж не всі параметри передаються
| @@ -0,0 +1,14 @@ | |||
| class CalculatorsSerializer < ApplicationService | |||
app/models/calculator.rb
Outdated
| } | ||
| validates :color, format: { with: /\A#[0-9a-fA-F]{6}\z/ } | ||
|
|
||
| scope :order_by_name, ->(params) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| scope :order_by_name, ->(params) { | |
| scope :order_by_name, ->(order_direction) { |
Hanna4007
commented
May 24, 2025
Contributor
Author
There was a problem hiding this comment.
Спочатку просто зробила
I18n.locale = :uk
але рубокоп сварився, що треба блок
loqimean
reviewed
May 26, 2025
| @@ -0,0 +1,13 @@ | |||
| class Api::V2::CalculatorsController < Api::V2::ApplicationController | |||
| def index | |||
| calculators = collection.order_by_name(params[:name]) | |||
Collaborator
There was a problem hiding this comment.
але до речі та, давай краще запермітим
| let(:attribute_without_locale) { "color" } | ||
|
|
||
| context "when current locale column exists" do | ||
| it "returns the column name for the current locale" do |
Collaborator
There was a problem hiding this comment.
one expect per example please
loqimean
approved these changes
May 28, 2025
lizaaadrozd
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What was done aside from the main task as a part of this PR?
Changes
Added an index action to CalculatorsController, which:
What is the current behavior?
Currently the list is not available via API
What is the expected behavior?
The API should return a JSON list of calculators with name and notes, sorted by localized name