Skip to content

Conversation

@federico-ntr
Copy link
Contributor

Fixes #

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Changes proposed in this Pull Request:

@vercel
Copy link

vercel bot commented Oct 7, 2025

@federico-ntr is attempting to deploy a commit to the dip-trasformazione-digitale Team on Vercel.

A member of the Team first needs to authorize it.

@federico-ntr
Copy link
Contributor Author

Note mainly for me:

Comparing the storybooks after removing the spans. Here's what's wrong/different for now:

  • Dropdown -> Menu icona a destra: missing space between text and icon, it may be a bug or that I removed the wrong span
  • Dropdown -> Menu dark: same as above

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
design-react-kit Ready Ready Preview Oct 24, 2025 4:32pm

@federico-ntr federico-ntr force-pushed the auto-span-link-dropdown branch from 21e5f55 to 2eaa9ab Compare October 30, 2025 11:46
@federico-ntr
Copy link
Contributor Author

I changed my mind about this change, as it would probably be breaking. It's probably better to fix the storybook and keep this change for the next major release. @astagi what do you think about it? Tagging you because we talked about this in the Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant