Skip to content

Refactor Rust toolchain management #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j178 merged 4 commits into from
Dec 8, 2025
+586 −406
Merged

Refactor Rust toolchain management #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
986f9ae
Refactor Rust toolchain management
j178 Nov 9, 2025
56f430a
Fix tests
j178 Dec 8, 2025
719db75
Avoid using bare cargo
j178 Dec 8, 2025
e950caf
Update crates/prek-consts/src/env_vars.rs
j178 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/prek-consts/src/env_vars.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ impl EnvVars {
"PREK_INTERNAL__RUN_ORIGINAL_PRE_COMMIT";
pub const PREK_INTERNAL__GO_BINARY_NAME: &'static str = "PREK_INTERNAL__GO_BINARY_NAME";
pub const PREK_INTERNAL__NODE_BINARY_NAME: &'static str = "PREK_INTERNAL__NODE_BINARY_NAME";
pub const PREK_INTERNAL__RUST_BINARY_NAME: &'static str = "PREK_INTERNAL__RUST_BINARY_NAME";
pub const PREK_INTERNAL__RUSTUP_BINARY_NAME: &'static str = "PREK_INTERNAL__RUSTUP_BINARY_NAME";
pub const PREK_GENERATE: &'static str = "PREK_GENERATE";

// Python & uv related
Expand Down
2 changes: 1 addition & 1 deletion docs/todo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ The original pre-commit supports hooks written in 10+ languages. The table below
| python ⭐ | ✅ Supported | — | `prek` supports automatic version management of Python toolchains. |
| node | ✅ Supported | — | |
| golang | ✅ Supported | — | |
| rust | ✅ Supported | — | |
| lua | ✅ Supported | — | |
| system | ✅ Supported | — | |
| script | ✅ Supported | — | |
Expand All @@ -24,7 +25,6 @@ The original pre-commit supports hooks written in 10+ languages. The table below
| fail | ✅ Supported | — | |
| deno ⭐ | 🚧 WIP | — | Experimental support in `prek`; upstream `pre-commit` lacks a native `deno` language. |
| ruby | 🚧 WIP | [#43](https://github.com/j178/prek/issues/43) | `prek` does not currently support downloading new Ruby versions, but can use multiple simultaneously installed interpreters |
| rust | 🚧 Planned | [#44](https://github.com/j178/prek/issues/44) | |
| conda | 🚧 Planned | [#52](https://github.com/j178/prek/issues/52) | |
| coursier | 🚧 Planned | [#53](https://github.com/j178/prek/issues/53) | |
| dart | 🚧 Planned | [#51](https://github.com/j178/prek/issues/51) | |
Expand Down
2 changes: 1 addition & 1 deletion src/languages/golang/golang.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ impl LanguageImpl for Golang {
let progress = reporter.on_install_start(&hook);

// 1. Install Go
let go_dir = store.tools_path(crate::store::ToolBucket::Go);
let go_dir = store.tools_path(ToolBucket::Go);
let installer = GoInstaller::new(go_dir);

let (version, allows_download) = match &hook.language_request {
Expand Down
Loading