Remove unused shared/grpc_client #7713

yurishkuro · 2025-12-07T20:18:30Z

No description provided.

Signed-off-by: Yuri Shkuro <[email protected]>

codecov · 2025-12-07T20:26:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.27%. Comparing base (22b0b0e) to head (1b9f665).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7713      +/-   ##
==========================================
+ Coverage   96.20%   96.27%   +0.06%     
==========================================
  Files         313      312       -1     
  Lines       16015    15879     -136     
==========================================
- Hits        15408    15288     -120     
+ Misses        447      437      -10     
+ Partials      160      154       -6

Flag	Coverage Δ
badger_v1	`9.52% <ø> (+0.14%)`	⬆️
badger_v2	`1.99% <ø> (+0.02%)`	⬆️
cassandra-4.x-v1-manual	`13.54% <ø> (+0.20%)`	⬆️
cassandra-4.x-v2-auto	`1.98% <ø> (+0.02%)`	⬆️
cassandra-4.x-v2-manual	`1.98% <ø> (+0.02%)`	⬆️
cassandra-5.x-v1-manual	`13.54% <ø> (+0.20%)`	⬆️
cassandra-5.x-v2-auto	`1.98% <ø> (+0.02%)`	⬆️
cassandra-5.x-v2-manual	`1.98% <ø> (+0.02%)`	⬆️
clickhouse	`1.91% <ø> (+0.02%)`	⬆️
elasticsearch-6.x-v1	`18.08% <ø> (+0.27%)`	⬆️
elasticsearch-7.x-v1	`18.11% <ø> (+0.27%)`	⬆️
elasticsearch-8.x-v1	`18.27% <ø> (+0.27%)`	⬆️
elasticsearch-8.x-v2	`1.99% <ø> (+0.02%)`	⬆️
elasticsearch-9.x-v2	`1.99% <ø> (+0.02%)`	⬆️
grpc_v1	`9.32% <ø> (+0.14%)`	⬆️
grpc_v2	`1.99% <ø> (+0.02%)`	⬆️
kafka-3.x-v2	`1.99% <ø> (+0.02%)`	⬆️
memory_v2	`1.99% <ø> (+0.02%)`	⬆️
opensearch-1.x-v1	`18.16% <ø> (+0.27%)`	⬆️
opensearch-2.x-v1	`18.16% <ø> (+0.27%)`	⬆️
opensearch-2.x-v2	`1.99% <ø> (+0.02%)`	⬆️
opensearch-3.x-v2	`1.99% <ø> (+0.02%)`	⬆️
query	`1.99% <ø> (+0.02%)`	⬆️
tailsampling-processor	`0.57% <ø> (+<0.01%)`	⬆️
unittests	`94.88% <ø> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-12-07T20:34:06Z

Metrics Comparison Summary

Total changes across all snapshots: 53

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 53

🆕 Added: 0 metrics
❌ Removed: 53 metrics
🔄 Modified: 0 metrics

❌ Removed Metrics

http_server_request_body_size_bytes (18 variants)

View diff sample

-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_request_duration_seconds` (17 variants)

View diff sample

-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_response_body_size_bytes` (18 variants)

View diff sample

-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

➡️ View full metrics file

Remove unused shared/grpc_client

1b9f665

Signed-off-by: Yuri Shkuro <[email protected]>

yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Dec 7, 2025

yurishkuro requested a review from a team as a code owner December 7, 2025 20:18

yurishkuro requested a review from jkowall December 7, 2025 20:18

dosubot bot added the area/storage label Dec 7, 2025

mahadzaryab1 approved these changes Dec 7, 2025

View reviewed changes

jaegertracingbot approved these changes Dec 7, 2025

View reviewed changes

yurishkuro added this pull request to the merge queue Dec 7, 2025

yurishkuro removed this pull request from the merge queue due to a manual request Dec 7, 2025

yurishkuro merged commit a54a36e into jaegertracing:main Dec 7, 2025
86 of 87 checks passed

yurishkuro deleted the rm-shared-grpc-client branch December 7, 2025 20:59

Copilot AI mentioned this pull request Dec 7, 2025

Replace manual release build process with goreleaser (v2 only) #7693

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove unused shared/grpc_client #7713

Remove unused shared/grpc_client #7713

yurishkuro commented Dec 7, 2025

Uh oh!

codecov bot commented Dec 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 7, 2025 •

edited

Loading

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

❌ Removed Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remove unused shared/grpc_client #7713

Remove unused shared/grpc_client #7713

Conversation

yurishkuro commented Dec 7, 2025

Uh oh!

codecov bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Metrics Comparison Summary

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

❌ Removed Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Dec 7, 2025 •

edited

Loading

github-actions bot commented Dec 7, 2025 •

edited

Loading