Remove deprecated namespace concept from Cassandra storage options #7719
Conversation
Co-authored-by: yurishkuro <[email protected]>
Co-authored-by: yurishkuro <[email protected]>
yurishkuro
added
the
changelog:refactoring
|
@copilot make sure you can run Error: internal/storage/integration/cassandra_test.go:71:3: unknown field NamespaceConfig in struct literal of type "github.com/jaegertracing/jaeger/internal/storage/v1/cassandra".Options |
Co-authored-by: yurishkuro <[email protected]>
Fixed in commit ecf151e. Updated the integration test to use the simplified Options structure. All three commands now pass successfully:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
| ProcessTags: true, | ||
| Logs: true, | ||
| }, | ||
| ArchiveEnabled: false, |
There was a problem hiding this comment.
redundant, can skip
| ArchiveEnabled: false, |
| ProcessTags: true, | ||
| }, | ||
| SpanStoreWriteCacheTTL: time.Hour * 12, | ||
| ArchiveEnabled: false, |
There was a problem hiding this comment.
redundant, can skip
| ArchiveEnabled: false, |
| }, | ||
| Configuration: config.DefaultConfiguration(), | ||
| SpanStoreWriteCacheTTL: time.Hour * 12, | ||
| ArchiveEnabled: false, |
There was a problem hiding this comment.
redundant, can skip
| ArchiveEnabled: false, |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7719 +/- ##
==========================================
+ Coverage 95.59% 95.61% +0.02%
==========================================
Files 311 311
Lines 15517 15511 -6
==========================================
- Hits 14833 14831 -2
+ Misses 535 532 -3
+ Partials 149 148 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove namespace concept from Cassandra options
Since v1 binaries have been deprecated, the namespace concept is no longer needed. This PR simplifies the configuration structs.
Changes Made:
Summary:
This PR successfully removes the deprecated namespace concept from the Cassandra storage options:
NamespaceConfigstruct that unnecessarily wrappedconfig.Configurationnamespacestring field (was only used for distinguishing archive storage)ArchiveEnabledbool field for clarityNewOptions()constructor to take no parametersIsArchiveCapable()to simply check theArchiveEnabledfieldAll tests pass successfully. The changes are backward compatible as they only affect internal implementation details.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.