Switch Basilisp test suite to use only 2 CPUs#876
Merged
Conversation
chrisrink10
commented
May 9, 2026
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Prepare dotnet | ||
| uses: xt0rted/setup-dotnet@v1.5.0 |
Contributor
Author
There was a problem hiding this comment.
I'm not sure why this action was selected, but it appears to be out of sync from the official setup-dotnet action from Github and hasn't been updated since 2022.
Member
There was a problem hiding this comment.
@dmiller Any reason to not use the official setup-dotnet?
Member
|
Thanks for the speedup, Chris! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest-xdist'sautooption can often be slower than setting a specific number of CPUs. I think standard Github Actions workers only have 2 vCPUs so this should end up actually being faster than usingauto.I also bumped the different Github Actions versions to use newer releases which use Node 24 to suppress some warnings during the runs.