Fix missing <type>pom</type> for groovy-all dependency#850
Open
ventura-bar wants to merge 1 commit intojfrog:masterfrom
Open
Fix missing <type>pom</type> for groovy-all dependency#850ventura-bar wants to merge 1 commit intojfrog:masterfrom
ventura-bar wants to merge 1 commit intojfrog:masterfrom
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing
<type>pom</type>forgroovy-alldependencyContext:
The
build-info-extractor-maven3package declares a dependency onorg.codehaus.groovy:groovy-all:3.0.13. Starting from version3.0.0, thegroovy-allpackage discontinued publishing the actual.jarartifact and was refactored into apompackaging type (aggregator).Bug:
Because the dependency definition in
build.gradleomits the artifact extension, the generatedpom.xmldefaults to ajartype. This causes downstream users in strict or offline environments (e.g., usingdependency:copy-dependencies) to suffer fatal--fail-at-endbuild crashes:Could not resolve dependencies [...] org.codehaus.groovy:groovy-all:jar:3.0.13 was not foundFix:
This PR simply appends
@pomto the dependency declaration inbuild.gradleso that themaven-publishplugin accurately generates the required<type>pom</type>in the resulting POM file, effectively resolving the dependency tree resolution failure.