Update Branch Name Template For Aggregated Fix#1238
Open
Update Branch Name Template For Aggregated Fix#1238
Conversation
Contributor
orto17
commented
Mar 2, 2026
orto17
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
- Update documentation about new features / new supported technologies
eranturgeman
approved these changes
Mar 4, 2026
Collaborator
eranturgeman
left a comment
eranturgeman
left a comment
There was a problem hiding this comment.
please open a similar PR to V3 if necessary
orto17
added
bug
github-actions
bot
removed
the
safe to test
Contributor
Comment on lines
535
to
549
| func (gm *GitManager) GenerateAggregatedFixBranchName(baseBranch string, tech []techutils.Technology) (fixBranchName string, err error) { | ||
| branchFormat := gm.customTemplates.branchNameTemplate | ||
| if branchFormat == "" { | ||
| branchFormat = AggregatedBranchNameTemplate | ||
| } | ||
| hash, err := Md5Hash("frogbot", baseBranch, techArrayToString(tech, fixBranchTechSeparator)) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| return formatStringWithPlaceHolders(branchFormat, "", "", hash, baseBranch, false), nil | ||
| if branchFormat != AggregatedBranchNameTemplate { | ||
| return formatStringWithPlaceHolders(branchFormat, "", "", hash, "", false), nil // custom: no suffix | ||
| } else { | ||
| return formatStringWithPlaceHolders(branchFormat, "", "", hash, baseBranch, false), nil // default: append base branch | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
entire logic can be simplified
Suggested change
| } | |
| func (gm *GitManager) GenerateAggregatedFixBranchName(baseBranch string, tech []techutils.Technology) (fixBranchName string, err error) { | |
| hash, err := Md5Hash("frogbot", baseBranch, techArrayToString(tech, fixBranchTechSeparator)) | |
| if err != nil { | |
| return "", err | |
| } | |
| branchFormat := gm.customTemplates.branchNameTemplate | |
| if branchFormat == "" { | |
| branchFormat = AggregatedBranchNameTemplate | |
| return formatStringWithPlaceHolders(branchFormat, "", "", hash, baseBranch, false), nil | |
| } | |
| return formatStringWithPlaceHolders(branchFormat, "", "", hash, "", false), nil | |
| } |
| } | ||
| return formatStringWithPlaceHolders(branchFormat, "", "", hash, baseBranch, false), nil | ||
| if branchFormat != AggregatedBranchNameTemplate { | ||
| return formatStringWithPlaceHolders(branchFormat, "", "", hash, "", false), nil // custom: no suffix |
Collaborator
There was a problem hiding this comment.
please add comments above the rows.
or you can simply remove them as they dont add much value
eranturgeman
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.