Added logic for adding python script by embed package#395
Merged
naveenku-jfrog merged 10 commits intojfrog:mainfrom Mar 17, 2026
Conversation
naveenku-jfrog
had a problem deploying
to
frogbot
GitHub Actions
Failure
naveenku-jfrog
added
bug
github-actions
bot
removed
the
safe to test
naveenku-jfrog
had a problem deploying
to
frogbot
GitHub Actions
Failure
naveenku-jfrog
added
the
safe to test
github-actions
bot
removed
the
safe to test
…-go-binary-through-embed-package
naveenku-jfrog
had a problem deploying
to
frogbot
GitHub Actions
Failure
naveenku-jfrog
added
the
safe to test
github-actions
bot
removed
the
safe to test
naveenku-jfrog
had a problem deploying
to
frogbot
GitHub Actions
Failure
…-go-binary-through-embed-package
…-go-binary-through-embed-package
bhanurp
approved these changes
Mar 16, 2026
| return err | ||
| } | ||
| defer func(path string) { | ||
| err = os.RemoveAll(path) |
Collaborator
There was a problem hiding this comment.
nit: to make it more clear since outer block of defer is already using err.
Suggested change
| err = os.RemoveAll(path) | |
| removeErr := os.RemoveAll(path) |
Collaborator
Author
There was a problem hiding this comment.
Addressed it.
| "github.com/jfrog/jfrog-client-go/utils/log" | ||
| ) | ||
|
|
||
| const DATASET = "dataset" |
Collaborator
There was a problem hiding this comment.
I coudn't find where is this used.
Collaborator
Author
There was a problem hiding this comment.
Addressed it.
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if latestRevision == "" { |
Collaborator
There was a problem hiding this comment.
does adding a warn log help here? otherwise it is silent return
Collaborator
Author
There was a problem hiding this comment.
Addressed it.
naveenku-jfrog
had a problem deploying
to
frogbot
GitHub Actions
Failure
…-go-binary-through-embed-package
Contributor
naveenku-jfrog
deleted the
fix/Update-logic-for-adding-python-script-in-go-binary-through-embed-package
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Added logic for adding python script by embed package
WHy: Huggingface download and upload scripts are not added in jfrog-cli binaries.
Testing: Done, by sharing jfrog-cli with changes and running it on the teammates's system