Export `JFROG_CLI_GITHUB_TOKEN` env var by nirvanin · Pull Request #288 · jfrog/setup-jfrog-cli

nirvanin · 2025-07-21T10:53:07Z

All tests passed. If this feature is not already covered by the tests, I added new tests.
I used npm run format for formatting the code before submitting the pull request.

github-actions · 2025-07-21T10:53:17Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

nirvanin · 2025-07-27T08:31:07Z

I have read the CLA Document and I hereby sign the CLA

RemiBou · 2025-07-29T07:00:15Z

lib/utils.js

-            let cliConfigCmd = ['config'];
+            let cliConfigCmd = [];
+            let githubToken = jfrogCredentials.githubToken;
+            if (!!githubToken) {


why do we have this in both ts and js ?

actually js is locally compiled from ts, and both of them are added to git. I also was surprised, but it's how it's organized now

EyalDelarea

Hey,
I know it seems just to pass an extra value to the jf c add command but i do have a few questions.

I didn't see the param documented in the CLI itself
There is no docs here or in the CLI what is token used for and what is the purpose of this token.
What happens if i have multiple GitHub tokens for multiple repos, which they are all connected to one jfrog instance?
We should check CLI version before adding the extra param and make sure we are backwards compatible

EyalDelarea · 2025-08-06T07:40:32Z

src/utils.ts


    public static async configJFrogServers(jfrogCredentials: JfrogCredentials) {
-        let cliConfigCmd: string[] = ['config'];
+        let cliConfigCmd: string[] = [];


I didn't see the param in the config add params:

It's global flag, relevant not only for configuration.

jf --help GLOBAL OPTIONS: --github-token value Github token which is used to call github api

there is no need to have access to different repos, github call is only used for cli version self-check on github releases, which is public.

it's backward compatible, updated cli can be used without github token param and old cli can be called with github token param.

Okay
So if it is not server specific, let's maybe move it to another place so it will be clear.

EyalDelarea · 2025-08-06T07:41:01Z

package.json

 {
    "name": "@jfrog/setup-jfrog-cli",
-    "version": "4.5.11",
+    "version": "4.5.12",


This could be done in a separate PR just to bump version before release

src/utils.ts

EyalDelarea · 2025-08-07T12:02:23Z

src/utils.ts

        Utils.exportVariableIfNotSet('JFROG_CLI_SOURCECODE_REPOSITORY', process.env.GITHUB_REPOSITORY ?? '');
        Utils.exportVariableIfNotSet('JFROG_CLI_CI_JOB_ID', process.env.GITHUB_WORKFLOW ?? '');
        Utils.exportVariableIfNotSet('JFROG_CLI_CI_RUN_ID', process.env.GITHUB_RUN_ID ?? '');
+        Utils.exportVariableIfNotSet('JFROG_CLI_GITHUB_TOKEN', process.env.GITHUB_TOKEN ?? '');


nirvanin had a problem deploying to frogbot July 21, 2025 10:53 — with GitHub Actions Failure

nirvanin force-pushed the feature/JPI-396 branch from 460cefd to f38951e Compare July 27, 2025 08:27

nirvanin had a problem deploying to frogbot July 27, 2025 08:27 — with GitHub Actions Failure

nirvanin force-pushed the feature/JPI-396 branch from f38951e to 282a03a Compare July 28, 2025 12:50

nirvanin had a problem deploying to frogbot July 28, 2025 12:50 — with GitHub Actions Failure

nirvanin force-pushed the feature/JPI-396 branch from 282a03a to be829f3 Compare July 28, 2025 13:28

nirvanin had a problem deploying to frogbot July 28, 2025 13:28 — with GitHub Actions Failure

nirvanin force-pushed the feature/JPI-396 branch from be829f3 to dd7932d Compare July 28, 2025 13:30

nirvanin had a problem deploying to frogbot July 28, 2025 13:30 — with GitHub Actions Failure

nirvanin force-pushed the feature/JPI-396 branch from dd7932d to aa57b84 Compare July 28, 2025 13:41

nirvanin had a problem deploying to frogbot July 28, 2025 13:41 — with GitHub Actions Failure

nirvanin force-pushed the feature/JPI-396 branch from aa57b84 to d79018d Compare July 28, 2025 14:21

nirvanin had a problem deploying to frogbot July 28, 2025 14:21 — with GitHub Actions Failure

RemiBou approved these changes Jul 29, 2025

View reviewed changes

nirvanin force-pushed the feature/JPI-396 branch from d79018d to d981cf1 Compare July 29, 2025 12:41

nirvanin had a problem deploying to frogbot July 29, 2025 12:41 — with GitHub Actions Failure

EyalDelarea suggested changes Aug 6, 2025

View reviewed changes

nirvanin force-pushed the feature/JPI-396 branch from d981cf1 to bd85021 Compare August 6, 2025 14:20

nirvanin had a problem deploying to frogbot August 6, 2025 14:20 — with GitHub Actions Failure

EyalDelarea linked an issue Aug 7, 2025 that may be closed by this pull request

action consumes github anonymous rest api rate limit #223

Closed

JPI-396 - add github token param

409f91e

nirvanin force-pushed the feature/JPI-396 branch from bd85021 to 409f91e Compare August 7, 2025 11:58

nirvanin had a problem deploying to frogbot August 7, 2025 11:58 — with GitHub Actions Failure

EyalDelarea reviewed Aug 7, 2025

View reviewed changes

EyalDelarea approved these changes Aug 7, 2025

View reviewed changes

EyalDelarea added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Aug 7, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 7, 2025

EyalDelarea changed the title ~~JPI-396 - add github token param~~ Export JFROG_CLI_GITHUB_TOKEN env var Aug 7, 2025

EyalDelarea added bug Something isn't working and removed improvement Automatically generated release notes labels Aug 11, 2025

EyalDelarea merged commit 88389c9 into jfrog:master Aug 11, 2025
37 of 50 checks passed

Conversation

nirvanin commented Jul 21, 2025 • edited by EyalDelarea Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nirvanin commented Jul 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EyalDelarea left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nirvanin commented Jul 21, 2025 •

edited by EyalDelarea

Loading

github-actions bot commented Jul 21, 2025 •

edited

Loading