Conversation
|
Ha! I love the test it's very clever. 😊 Even though the tooltip is very good, I think "pairwise point addition mode" is fairly obscure, especially since eventually all modes are pairwise point addition modes. 😂 My alternative suggestion is to use an enum: Initial point annotation = alternating / grouped by layer Tooltip: Before affinder can have an initial transform estimate, it needs ndim + 1 points to match between reference and moving layers. In alternating mode, you pick one point in reference, then its corresponding point in moving, and so on. In grouped mode, you first pick ndim + 1 points in the reference layer, then ndim + 1 in the moving layer in the same order, before alternating. |
|
Thanks for your suggestions @jni which I completely agree with! Just pushed the changes. |
|
Thanks @m-albert! Would you mind appending an "Update" section to the original post with an up to date screenshot? That way the commit message will contain the picture corresponding to the final state of the PR. 🙏 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 91.95% 92.32% +0.37%
==========================================
Files 8 8
Lines 373 391 +18
==========================================
+ Hits 343 361 +18
Misses 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jni Done! |
|
This is now released as 0.5.0. 🥳 |
|
Amazing, thank you @jni! |
Implements the proposed pairwise clicking mode detailed in #100:
Let me know what you think @jni! Happy to include any changes / improvements.
Screenshot:

Update
After incorporating @jni's improvements and at the final state of the PR the plugin looks like this: