Fix useEffect deps causing toast spam on EarnPage

[kunal-595]

The start/stop mutation objects are new refrences on each render, causing both effects to run repetedly, narrowed dependencies to isSuccess and reset, which are the only values used, to prevent repeated toasts and resets

[Copilot]

Pull request overview

This PR fixes a bug where toast notifications were being displayed repeatedly on the EarnPage due to incorrect useEffect dependency arrays. The mutation objects returned by React Query's useMutation are new references on each render, causing effects to run continuously. The fix narrows the dependencies to only include the specific properties that matter: isSuccess for detecting successful mutations and reset for cleanup.

Changes:

• Replaced entire startMaker mutation object in useEffect deps with specific properties startMaker.isSuccess and startMaker.reset
• Replaced entire stopMaker mutation object in useEffect deps with specific properties stopMaker.isSuccess and stopMaker.reset
• Added eslint-disable comments to suppress warnings about stable function dependencies (toast, scrollToTop)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[theborakompanioni]

I guess this was introduced in a recent PR when the isWaitingMakerStart was moved from the useMutation hook, right? Can we revert to the old approach? What do you think?

[theborakompanioni]

I am not experiencing this behaviour - it is currently not optimal, but I do not see what this fixes. Can you elaborate?

[kunal-595]

thanks for checking after re-testing on latest v2, I do not see any user visible impact. The change was mainly to tighten the effect dependencies ,if reverting to the previous isWaitingMakerStart approach is preferred for consistency, i am happy to switch.

[theborakompanioni]

thanks for checking after re-testing on latest v2, I do not see any user visible impact. The change was mainly to tighten the effect dependencies ,if reverting to the previous isWaitingMakerStart approach is preferred for consistency, i am happy to switch.

I have a small refactor regarding this and will push it soon, okay for you?

[theborakompanioni]

Closing this in favour of #1144 - please reopen if you think this is a mistake or if #1144 does not solve your issue. 🙏