Fix registration in isolate with V2 embedding#40
Open
xiprox wants to merge 1 commit into
Open
Conversation
Contributor
|
I've implemented a more-complete version with example app change in #44 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
registrar.activity() must not be nullexception caused by the plugin depending on an activity when being registered, which, is not available in an isolate.While at it, this PR also upgrades to V2 Embedding.
Unfortunately, my time is very limited, so I will only be able to create this PR with a fix on the plugin, and won't be able to spend more time updating the example app as well. For the same reason, I haven't done any testing beyond confirming it works for my use case.