Conversation
Separated Basic and Extended Authorisation Service Interfaces
…thorisation-service
proposed/authorisation-service.md
Outdated
| * | ||
| * @return UserInterface[] | ||
| */ | ||
| public function getUsers($action, $classOrObject = null): array; |
There was a problem hiding this comment.
should be getActors imho - the same as is in description - user implies humans
proposed/authorisation-service.md
Outdated
| * | ||
| * @return object[] | ||
| */ | ||
| public function getObjects($roleOrUser, $action, $class = null): array; |
There was a problem hiding this comment.
Also this one should be something more abstract - target or entity as in your description
proposed/authorisation-service.md
Outdated
| * | ||
| * @param UserInterface $user The user that will take action | ||
| * @param string $action The action to be taken | ||
| * @param string|object $classOrObject The class or object to act on. |
There was a problem hiding this comment.
Rename parameters in accordance with description https://github.com/joomla-x/joomla-standards/pull/2/files#diff-b75c3483f869c0812ec55be2719fa3c3R28
|
I basically agree with proposed RCF, but all methods and variables should be named in abstract way not bound to specific implementations, as it is done in description https://github.com/joomla-x/joomla-standards/pull/2/files#diff-b75c3483f869c0812ec55be2719fa3c3R28 |
|
@klas Thank you for your feedback, made according changes. |
# Conflicts: # README.md # bylaws/workflow.md # index.md
2 participants
Proposal for a (generic) interface for Authorisation Services.