Fix compilation with Cython3.1. #1184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to ahesford: Failure to compile with Cython 3.1 is caused by a collision between struct hackrf_device_list and the function hackrf_device_list. In the C library that this wraps, the two names are distinct. Cython, however, folds struct hackrf_device_list into just hackrf_device_list. Fortunately, Cython allows the use of a name for its definitions that differs from the underlying C name, so the struct can just be called c_hackrf_device_list. This doesn't seem to be a critical change because the immediately following typedef just aliases this to hackrf_device_list_t everywhere it is needed. Cf. http://docs.cython.org/en/stable/src/userguide/external_C_code.html#resolving-naming-conflicts-c-name-specifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to ahesford:
Failure to compile with Cython 3.1 is caused by a collision between struct hackrf_device_list and the function hackrf_device_list. In the C library that this wraps, the two names are distinct. Cython, however, folds struct hackrf_device_list into just hackrf_device_list. Fortunately, Cython allows the use of a name for its definitions that differs from the underlying C name, so the struct can just be called c_hackrf_device_list. This doesn't seem to be a critical change because the immediately following typedef just aliases this to hackrf_device_list_t everywhere it is needed.
Cf. http://docs.cython.org/en/stable/src/userguide/external_C_code.html#resolving-naming-conflicts-c-name-specifications