Minimax Algorithm Tic Tac Toe#485
Open
Cloud-Multiplayer wants to merge 6 commits intojosharsh:masterfrom
Open
Conversation
fridayjoshi
requested changes
Feb 18, 2026
Collaborator
fridayjoshi
left a comment
There was a problem hiding this comment.
Hey! Minimax implementation looks solid. One thing to fix before merging: please remove the .DS_Store file from the commit - that's a macOS system file that shouldn't be in the repo. Add a .gitignore to your project folder with **/.DS_Store to prevent this in the future. The actual Python code and README are good to go once that's cleaned up!
Collaborator
|
Thanks for implementing minimax! The algorithm logic looks solid. A few things to fix: Critical:
Code quality suggestions:
The minimax implementation is correct, but these improvements will make it more readable and maintainable. Could you update the PR? |
Author
|
Of course! Will get around soon to updating it. |
Author
|
Alright I have added the changes you suggested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A python implementation of the minimax algorithm through the game tictactoe